Repository navigation
Conversation
IrynaKulakova
approved these changes
Oct 13, 2026
IrynaKulakova
left a comment
Contributor
There was a problem hiding this comment.
Reviewed commit 4dbf51a. No actionable findings: the merged_at fallback preserves explicit merged values and is shared by text and structured output. Local lint and tests could not run because the installed Go binaries fail with "Bad CPU type in executable"; this approval is based on code inspection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct
list_pull_requestsoutput for merged pull requests when the REST list endpoint omits themergedboolean. Use a nonzeromerged_atas a fallback while preserving an explicit boolean.Why
An agent listing closed PRs currently sees
merged: falseeven for merged changes, which can corrupt contribution summaries. The regression uses raw REST JSON from the list response.Fixes #3467
What changed
merged.MCP impact
The existing
mergedoutput now correctly describes list entries. No input or output fields are added.Prompts tested (tool changes only)
Regression calls use
list_pull_requestswithowner,repo, andstate: "all", both with all fields and withfields: ["number", "merged", "merged_at"]. No natural-language model prompts were run.Security / limits
The conversion uses data already returned by the API and adds no requests.
Tool renaming
Lint & tests
Validated against main
b98d115bbb080e9555466a96656ec4df605aea21on macOS arm64:script/lintwith golangci-lint 2.14.0 (0 issues),script/test(go test -race ./...; 30 packages passed, six without tests),go mod tidy -diff, and the server build passed.UPDATE_TOOLSNAPS=true, including 12 merged-state/field-selection cases through text and SDK structured output. All 141 schema snapshots stayed unchanged.script/generate-docspassed; all five generated documents stayed unchanged.npm ci, type checking, and 11 UI tests passed. Four embedded pages built with the current Vite configuration through a reviewed helper that preserves output renaming and omits recursive directory cleanup. The standardnpm run buildcommand was not run.npm auditreports four high-severity dependency entries. Main's exact package and lock files produce the same vulnerability graph; this change leaves them unchanged.Authenticated GitHub E2E tests and rendered MCP-host UI checks were not run. Local results do not establish upstream CI success.
Codex assisted with the code and tests. A separate Codex agent reviewed the merged-state conversion and both output paths.
Docs
This corrects an existing field without changing the tool schema.